----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/#review163380 -----------------------------------------------------------
src/common/protobuf_utils.hpp (line 100) <https://reviews.apache.org/r/56017/#comment235240> I think `UUID` should also be a required argument instead of auto-magically setting it to random. That way someone doesn't need to look at the comment to know which fields are updated and which fields are not. ``` // Create a new task status from the given task status. Specific fields in `status` can be over-ridden // in the new status by specifying the appropriate argument. TaskStatus createTaskStatus( const TaskStatus& status, const UUID& uuid, double timestamp, ...) ``` src/common/protobuf_utils.hpp (line 102) <https://reviews.apache.org/r/56017/#comment234804> we don't do const& for POD types. - Vinod Kone On Jan. 27, 2017, 12:54 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56017/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2017, 12:54 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/protobuf_utils.hpp faa7e2a759fd2b1ce5def662679f573ec6fefd28 > src/common/protobuf_utils.cpp 3ccda1ac2e94ef3fc20d6a2cdb94b6620d914bcd > > Diff: https://reviews.apache.org/r/56017/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rukletsov > >
