> On March 1, 2017, 7:46 p.m., Vinod Kone wrote: > > src/common/protobuf_utils.hpp > > Lines 96-98 (original), 98-100 (patched) > > <https://reviews.apache.org/r/56017/diff/1-2/?file=1617571#file1617571line98> > > > > The last sentence seems un-necssary because the it's clear from the > > arguments what fields can be overwritten?
I'd rather keep the comment (which should be updated by the way to include `uuid`) in order to make our intent explicit and for example catch situations when this helper and `TaskStatus` go out of sync. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/#review167556 ----------------------------------------------------------- On Feb. 28, 2017, 3:48 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56017/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 3:48 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/protobuf_utils.hpp 09e468c77f0cdd931302d1bdcc192370b6ce3340 > src/common/protobuf_utils.cpp 944263bbaa87a65005fd924bccfadb7293312fa0 > > > Diff: https://reviews.apache.org/r/56017/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rukletsov > >
