----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56421/#review164795 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On Feb. 7, 2017, 6:38 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56421/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 6:38 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > The executor and tasks fields in the agent's structs are publicly > visible, but yet for correctness it is required that callers made > modifications through the member functions which carry additional > logic (e.g. tracking allocated resources). The TODO here is to > make these private and to provide public views that are const. > > > Diffs > ----- > > src/slave/slave.hpp 5049eb783b8ad7b9599f20c3701f7d3d654b4491 > > Diff: https://reviews.apache.org/r/56421/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
