----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56366/#review164828 -----------------------------------------------------------
Bad patch! Reviews applied: [56366, 56364, 56363] Failed command: python support/apply-reviews.py -n -r 56366 Error: 2017-02-09 02:37:50 URL:https://reviews.apache.org/r/56366/diff/raw/ [5273/5273] -> "56366.patch" [1] error: patch failed: src/launcher/executor.cpp:140 error: src/launcher/executor.cpp: patch does not apply Full log: https://builds.apache.org/job/Mesos-Reviewbot/17030/console - Mesos Reviewbot On Feb. 8, 2017, 9:16 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56366/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 9:16 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-6892 > https://issues.apache.org/jira/browse/MESOS-6892 > > > Repository: mesos > > > Description > ------- > > The executor now owns the `SharedHandle` for the process and job object, > so that their lifetime is correctly tied to the executor and their > handles will be closed properly. > > > Diffs > ----- > > src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9 > src/launcher/windows/executor.hpp 6f02912c477105819b4c27ddf248b7289799eaa0 > src/launcher/windows/executor.cpp b51fde7376c2083119f342ea599b446944ede000 > > Diff: https://reviews.apache.org/r/56366/diff/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
