----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56530/#review165070 -----------------------------------------------------------
Patch looks great! Reviews applied: [56530] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 10, 2017, 6:10 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56530/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2017, 6:10 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and > Michael Park. > > > Bugs: MESOS-6940 > https://issues.apache.org/jira/browse/MESOS-6940 > > > Repository: mesos > > > Description > ------- > > In a mixed cluster, when an old agent (not MULTI_ROLE capable) > registers with new master (MULTI_ROLE capable), it cannot correctly > handle tasks from a MULTI_ROLE framework. Therefore, we should > disallow offers from these agents being sent to MULTI_ROLE frameworks. > > > Diffs > ----- > > src/master/master.cpp 620919ecfe85367b5c1281afc5216cc20e5e2e3c > src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18 > > Diff: https://reviews.apache.org/r/56530/diff/ > > > Testing > ------- > > WIP > > ./bin/mesos-tests.sh > --gtest_filter="MasterTest.MultiRoleFrameworkDoesNotReceiveOfferFromOldAgent" > --gtest_break_on_failure --gtest_repeat=-1 > > > Thanks, > > Jay Guo > >
