----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56530/#review166229 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (lines 1535 - 1544) <https://reviews.apache.org/r/56530/#comment238125> Hm.. I'm inclined to put this in `isFiltered` (like we had done for FrameworkInfo.checkpoint some time ago) since this is effectively an implicit filter. It also helps to avoid cluttering the allocation code here. Thoughts? src/master/allocator/mesos/hierarchical.cpp (lines 1540 - 1542) <https://reviews.apache.org/r/56530/#comment238123> How about: Implicitly filtering agent <ID> from framework <ID> because the framework is MULTI_ROLE capable but the agent is not (note, no periods at the end of logging) src/master/allocator/mesos/hierarchical.cpp (lines 1715 - 1718) <https://reviews.apache.org/r/56530/#comment238124> Ditto here. src/tests/hierarchical_allocator_tests.cpp (lines 214 - 238) <https://reviews.apache.org/r/56530/#comment238128> Can you pull this out into a separate patch? Also, I would suggest we just explicitly listen to the provided capabilities and `FAIL() << "xxx"` if the caller is inconsistent (i.e. `roles.size() > 1 && !MULTI_ROLE`). src/tests/hierarchical_allocator_tests.cpp (line 3748) <https://reviews.apache.org/r/56530/#comment238126> s/Not/Dont/ ? - Benjamin Mahler On Feb. 20, 2017, 4:48 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56530/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2017, 4:48 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and > Michael Park. > > > Bugs: MESOS-6940 > https://issues.apache.org/jira/browse/MESOS-6940 > > > Repository: mesos > > > Description > ------- > > In a mixed cluster, when an old agent (not MULTI_ROLE capable) > registers with new master (MULTI_ROLE capable), it cannot correctly > handle tasks from a MULTI_ROLE framework. Therefore, we should > disallow resources from these agents being allocated to MULTI_ROLE > frameworks. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > eeb44fe89d4bfd26900b11833c1182157e5c7e5c > src/tests/hierarchical_allocator_tests.cpp > 5441fa9d1fad1ca7819038db49c6d88e40571e4a > > Diff: https://reviews.apache.org/r/56530/diff/ > > > Testing > ------- > > ./bin/mesos-tests.sh > > > Thanks, > > Jay Guo > >
