-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56530/
-----------------------------------------------------------
(Updated Feb. 20, 2017, 12:46 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and
Michael Park.
Changes
-------
address benb and benm's comments
Summary (updated)
-----------------
Prevent resource of old agents being allocated to MULTI_ROLE frameworks.
Bugs: MESOS-6940
https://issues.apache.org/jira/browse/MESOS-6940
Repository: mesos
Description (updated)
-------
In a mixed cluster, when an old agent (not MULTI_ROLE capable)
registers with new master (MULTI_ROLE capable), it cannot correctly
handle tasks from a MULTI_ROLE framework. Therefore, we should
disallow resources from these agents being sent to MULTI_ROLE
frameworks.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp
eeb44fe89d4bfd26900b11833c1182157e5c7e5c
src/tests/hierarchical_allocator_tests.cpp
5441fa9d1fad1ca7819038db49c6d88e40571e4a
Diff: https://reviews.apache.org/r/56530/diff/
Testing
-------
./bin/mesos-tests.sh
--gtest_filter="MasterTest.MultiRoleFrameworkDoesNotReceiveOfferFromOldAgent"
--gtest_break_on_failure --gtest_repeat=-1
Thanks,
Jay Guo
