----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56375/#review165041 -----------------------------------------------------------
src/tests/master_tests.cpp (lines 1905 - 1909) <https://reviews.apache.org/r/56375/#comment237032> Do you want to add a TODO to test the other operations as well? src/tests/master_tests.cpp (lines 1932 - 1936) <https://reviews.apache.org/r/56375/#comment236879> We should probably clear_role() here in order to not assume that DEFAULT_FRAMEWORK_INFO has not set the role field. src/tests/master_tests.cpp (lines 1986 - 1987) <https://reviews.apache.org/r/56375/#comment237028> Is it possible to pause the clock for the whole test to ensure we're not depending on time? src/tests/master_tests.cpp (line 1993) <https://reviews.apache.org/r/56375/#comment237030> You can use the -> operator (e.g. `offers2->size()` or `offers2->at(0)`), feel free to sweep this file in a later patch. src/tests/master_tests.cpp (lines 1997 - 1998) <https://reviews.apache.org/r/56375/#comment237031> Does EXPECT_SOME_EQ not work here? src/tests/master_tests.cpp (line 2032) <https://reviews.apache.org/r/56375/#comment237035> This is a little hard to figure out, can you document their allocations to describe how we know that fair sharing will make these offers to different roles? Also, it seems to me we don't know which of the two roles will get the initial offer? - Benjamin Mahler On Feb. 7, 2017, 7:34 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56375/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 7:34 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu. > > > Bugs: MESOS-6637 > https://issues.apache.org/jira/browse/MESOS-6637 > > > Repository: mesos > > > Description > ------- > > Multi-role framework cannot combine offers allocated to different > roles of that framework in a single launchTask call. > > > Diffs > ----- > > src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18 > > Diff: https://reviews.apache.org/r/56375/diff/ > > > Testing > ------- > > Added a test > make check GTEST_FILTER="MasterTest.LaunchDifferentRoleLost" > > > Thanks, > > Jay Guo > >
