> On Feb. 11, 2017, 8:16 a.m., Benjamin Mahler wrote: > > src/tests/master_tests.cpp, line 2032 > > <https://reviews.apache.org/r/56375/diff/2/?file=1626156#file1626156line2032> > > > > This is a little hard to figure out, can you document their allocations > > to describe how we know that fair sharing will make these offers to > > different roles? Also, it seems to me we don't know which of the two roles > > will get the initial offer?
We could test combined offer as long as we can assert that 2nd and 3rd offers are made to different roles, even though the role of 1st offer is not deterministic, no? - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56375/#review165041 ----------------------------------------------------------- On Feb. 7, 2017, 3:34 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56375/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 3:34 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu. > > > Bugs: MESOS-6637 > https://issues.apache.org/jira/browse/MESOS-6637 > > > Repository: mesos > > > Description > ------- > > Multi-role framework cannot combine offers allocated to different > roles of that framework in a single launchTask call. > > > Diffs > ----- > > src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18 > > Diff: https://reviews.apache.org/r/56375/diff/ > > > Testing > ------- > > Added a test > make check GTEST_FILTER="MasterTest.LaunchDifferentRoleLost" > > > Thanks, > > Jay Guo > >
