----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56214/#review165771 -----------------------------------------------------------
See my comments in the previous review. Don't think we should do this. - Vinod Kone On Feb. 8, 2017, 4:57 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56214/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 4:57 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > Update acknowledgements contain UUID as string, a conversion is > anyway necessary. In the future we may not have access to the > original UUID, while string representation is always available in > the protobuf message itself. Hence it seems reasonable to hash > updates by string instead of UUID. > > > Diffs > ----- > > src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a > > Diff: https://reviews.apache.org/r/56214/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
