----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56812/#review166636 -----------------------------------------------------------
src/slave/http.cpp (line 831) <https://reviews.apache.org/r/56812/#comment238635> so previously we were sending an empty subject (`Subject()`) but now we are sending `Option::None()` to `getObjectApprover`? what's the difference? i wish this change was done in a separate review instead of mixing it here with the use of auth context. src/slave/http.cpp (line 833) <https://reviews.apache.org/r/56812/#comment238638> not related to your change, but I'm curious why this method uses the object approver whereas the `Slave::Http::flags()` doesn't? cc @arojas src/slave/http.cpp (line 968) <https://reviews.apache.org/r/56812/#comment238636> ditto. src/slave/http.cpp (line 1161) <https://reviews.apache.org/r/56812/#comment238637> ditto. here and everywhere else. - Vinod Kone On Feb. 22, 2017, 1:18 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56812/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2017, 1:18 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7003 > https://issues.apache.org/jira/browse/MESOS-7003 > > > Repository: mesos > > > Description > ------- > > This patch updates the HTTP endpoint handlers in the > agent process to accept an `AuthenticationContext` > instead of an `Option<string>& principal`. > > > Diffs > ----- > > src/slave/http.cpp 8a9fabf861369d3ae659dce21fa3932f6f7b9161 > src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2 > src/slave/slave.cpp 45905297836017e9031359894fc71e614c13cfcc > > Diff: https://reviews.apache.org/r/56812/diff/ > > > Testing > ------- > > Testing details can be found at the end of this review chain. > > > Thanks, > > Greg Mann > >
