----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56812/#review167902 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On March 3, 2017, 6:43 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56812/ > ----------------------------------------------------------- > > (Updated March 3, 2017, 6:43 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7003 > https://issues.apache.org/jira/browse/MESOS-7003 > > > Repository: mesos > > > Description > ------- > > This patch updates the HTTP endpoint handlers in the > agent process to accept the `Principal` type instead > of an `Option<string>& principal`. > > > Diffs > ----- > > src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59 > src/slave/slave.hpp 449971b6b343c7714e1d1167a55bbdfe94d2cf83 > src/slave/slave.cpp 6ae9458cc81a7623a1837cd636156434a972004b > > > Diff: https://reviews.apache.org/r/56812/diff/5/ > > > Testing > ------- > > Testing details can be found at the end of this review chain. > > > Thanks, > > Greg Mann > >