> On March 6, 2017, 9:26 p.m., Michael Park wrote: > > src/common/roles.cpp > > Lines 72 (patched) > > <https://reviews.apache.org/r/57166/diff/2/?file=1653834#file1653834line73> > > > > For these error messages, how about we say something like this? > > > > ```cpp > > "A role cannot start with a slash, given: '" + role + "'" > > ``` > > > > Here and below. > > Neil Conway wrote: > The "given" phrasing here seems confusing to me (it isn't clear who is > being "given" what...). Personally I think the current phrasing is okay...
Okay, I think I was just trying to suggest that the statement should make a general statement about all roles, rather than say the __particular role__ cannot <whatever>. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57166/#review168096 ----------------------------------------------------------- On March 7, 2017, 7:38 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57166/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 7:38 a.m.) > > > Review request for mesos, Benjamin Bannier and Michael Park. > > > Repository: mesos > > > Description > ------- > > Role names can now contain forward slashes. Each component in a role > name must now be validated separately. > > > Diffs > ----- > > src/common/roles.cpp 31774a9b8f99f5efeed35b1c3e3486e05ca00f6a > src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1 > > > Diff: https://reviews.apache.org/r/57166/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
