----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57166/#review171391 -----------------------------------------------------------
Ship it! Ship It! - Adam B On March 7, 2017, 7:38 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57166/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 7:38 a.m.) > > > Review request for mesos, Benjamin Bannier and Michael Park. > > > Repository: mesos > > > Description > ------- > > Role names can now contain forward slashes. Each component in a role > name must now be validated separately. > > > Diffs > ----- > > src/common/roles.cpp 31774a9b8f99f5efeed35b1c3e3486e05ca00f6a > src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1 > > > Diff: https://reviews.apache.org/r/57166/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
