----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57474/#review168596 -----------------------------------------------------------
Thanks for updating this, looks mostly good to me; I just hope the principals and roles you picked help everybody. Overall issues I believe we should fix: * We don't have existing tests for `UPDATE_WEIGHT` and `GET_QUOTA` we could update here. Since we add extra branching for these we should add tests now. * This file uses a very verbose commenting style while most of the new code you added has no comments. I am not sure the way comments are used here is effective, but let's try to be more consistent. src/tests/authorization_tests.cpp Lines 907 (patched) <https://reviews.apache.org/r/57474/#comment240858> `archbishop`. Here and everywhere else. - Benjamin Bannier On March 9, 2017, 7:26 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57474/ > ----------------------------------------------------------- > > (Updated March 9, 2017, 7:26 p.m.) > > > Review request for mesos, Adam B and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Adds tests for each of the actions which support hierarchical roles. > > > Diffs > ----- > > src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 > > > Diff: https://reviews.apache.org/r/57474/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Alexander Rojas > >
