----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/#review169265 -----------------------------------------------------------
src/launcher/default_executor.cpp Line 873 (original) <https://reviews.apache.org/r/56449/#comment241610> LOG or VLOG here? src/launcher/default_executor.cpp Lines 876 (patched) <https://reviews.apache.org/r/56449/#comment241611> what's the guarantee that the `healthChecker` is `Some` here? AFAICT `kill()` sets this to None() without erasing the container from the map. - Vinod Kone On March 16, 2017, 4:48 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56449/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 4:48 p.m.) > > > Review request for mesos, Anand Mazumdar, Gastón Kleiman, and Vinod Kone. > > > Bugs: MESOS-7249 > https://issues.apache.org/jira/browse/MESOS-7249 > > > Repository: mesos > > > Description > ------- > > With the recent introduction of the `Container` struct in the default > executor, tasks' health checkers should be moved to this struct. Also, > health checking is stopped on per-task basis and not on shutdown. > > > Diffs > ----- > > src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d > > > Diff: https://reviews.apache.org/r/56449/diff/3/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
