----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/#review165695 -----------------------------------------------------------
Ship it! src/launcher/default_executor.cpp (line 639) <https://reviews.apache.org/r/56449/#comment237555> Looks like making `healthChecker` an `Option` doesn't gain us much, since we still have to be defensive and do `CHECK_NOTNULL` before using it. - Gastón Kleiman On Feb. 8, 2017, 4:56 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56449/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 4:56 p.m.) > > > Review request for mesos, Anand Mazumdar, Gastón Kleiman, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > With the recent introduction of the `Container` struct in the default > executor, tasks' health checkers should be moved to this struct. Also, > health checking is stopped on per-task basis and not on shutdown. > > > Diffs > ----- > > src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a > > Diff: https://reviews.apache.org/r/56449/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
