----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/#review165770 -----------------------------------------------------------
src/launcher/default_executor.cpp (lines 635 - 637) <https://reviews.apache.org/r/56449/#comment237631> Now that this TODO is copied to `kill()`, don't think it makes sense to have it here? src/launcher/default_executor.cpp (line 869) <https://reviews.apache.org/r/56449/#comment237630> What's the guarantee that this task is still present in `containers`? AFAICT this is a deferred callback invoked by the health checker. - Vinod Kone On Feb. 8, 2017, 4:56 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56449/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 4:56 p.m.) > > > Review request for mesos, Anand Mazumdar, Gastón Kleiman, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > With the recent introduction of the `Container` struct in the default > executor, tasks' health checkers should be moved to this struct. Also, > health checking is stopped on per-task basis and not on shutdown. > > > Diffs > ----- > > src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a > > Diff: https://reviews.apache.org/r/56449/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
