----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56218/#review169278 -----------------------------------------------------------
Fix it, then Ship it! src/tests/check_tests.cpp Lines 846-848 (patched) <https://reviews.apache.org/r/56218/#comment241629> dont you want to do these tests for HTTP as well? src/tests/check_tests.cpp Lines 854 (patched) <https://reviews.apache.org/r/56218/#comment241628> can you add a TODO to cleanup this file as follows: 1) Move variables closer to their usage 2) Do not use evolve/devolve but use v1 variables/helpers wherever possible please take a look at default_executor_tests.cpp for an example. - Vinod Kone On March 16, 2017, 4:46 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56218/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 4:46 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-7249 > https://issues.apache.org/jira/browse/MESOS-7249 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/check_tests.cpp f035c16920deaf559420ae0d7d881330ff65ae44 > > > Diff: https://reviews.apache.org/r/56218/diff/5/ > > > Testing > ------- > > Tested the complete chain starting at https://reviews.apache.org/r/56208/ > make check > > > Thanks, > > Alexander Rukletsov > >
