----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56218/#review165703 -----------------------------------------------------------
Fix it, then Ship it! Nit: the summary is a bit misleading, you are only adding one test ;-). src/tests/check_tests.cpp (line 805) <https://reviews.apache.org/r/56218/#comment237564> Nit: s/http/HTTP/ src/tests/check_tests.cpp (lines 809 - 810) <https://reviews.apache.org/r/56218/#comment237566> We use less resources in all the tests in `default_executor_tests.cpp`: ``` Resources resources = Resources::parse("cpus:0.1;mem:32;disk:32").get(); ``` Why do we need more here? Shouldn't we be consistent with the tests in the other file? src/tests/check_tests.cpp (line 850) <https://reviews.apache.org/r/56218/#comment237567> `// Ignore subsequent offers.` src/tests/check_tests.cpp (line 902) <https://reviews.apache.org/r/56218/#comment237568> Vinod didn't like the `auto` in a similar test that is part of the same chain. If you follow his suggestion there, you should also follow it here. Drop this issue otherwise =). src/tests/check_tests.cpp (line 914) <https://reviews.apache.org/r/56218/#comment237569> ditto - Gastón Kleiman On Feb. 9, 2017, 12:56 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56218/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 12:56 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/check_tests.cpp b5a5d8e80c80b480992a3c8160ee7d0e4443111c > > Diff: https://reviews.apache.org/r/56218/diff/ > > > Testing > ------- > > Tested the complete chain starting at https://reviews.apache.org/r/56208/ > make check > > > Thanks, > > Alexander Rukletsov > >
