> On March 17, 2017, 11:07 a.m., Vinod Kone wrote: > > src/tests/check_tests.cpp > > Lines 846-848 (patched) > > <https://reviews.apache.org/r/56218/diff/5/?file=1666170#file1666170line846> > > > > dont you want to do these tests for HTTP as well?
I think doing the same for HTTP would be redundant: shadowing, timing out is not related to the check type. However, in order to ensure these things are indeed unrealated, we should better introduce a mocked checker. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56218/#review169278 ----------------------------------------------------------- On March 16, 2017, 4:46 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56218/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 4:46 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-7249 > https://issues.apache.org/jira/browse/MESOS-7249 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/check_tests.cpp f035c16920deaf559420ae0d7d881330ff65ae44 > > > Diff: https://reviews.apache.org/r/56218/diff/5/ > > > Testing > ------- > > Tested the complete chain starting at https://reviews.apache.org/r/56208/ > make check > > > Thanks, > > Alexander Rukletsov > >
