----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/#review169648 -----------------------------------------------------------
I'm still learning how review board works, so please let me know if I posted this incorrectly. Not sure if this is where comments go. There's another environment.cpp file in mesos-tests, but I was informed that I can't abstract something out that both mesos-tests and stout-tests relies on. The environment.cpp file in this review for stout-tests is basically a watered down version of the environment.cpp file in mesos-tests. This review checks if the user on Windows is able to create a symlink, and if so, enables tests that require the creation of symlinks. Otherwise, if unable to create a symlink, the tests that require the creation of symlinks are disabled. - John Kordich On March 21, 2017, 11:44 p.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57824/ > ----------------------------------------------------------- > > (Updated March 21, 2017, 11:44 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-6731 > https://issues.apache.org/jira/browse/MESOS-6731 > > > Repository: mesos > > > Description > ------- > > Filtered stout tests with symlinks when unable to create symlinks. > > > Diffs > ----- > > 3rdparty/stout/Makefile.am ebf1069eb1b787f063a2066a4db0b3f5de4a56da > 3rdparty/stout/tests/CMakeLists.txt > 4bbe713f259e7858d423dcb33956d41e62a915eb > 3rdparty/stout/tests/environment.hpp PRE-CREATION > 3rdparty/stout/tests/environment.cpp PRE-CREATION > 3rdparty/stout/tests/main.cpp f41b29c087402d5dbed1144504980746e0e9b6da > 3rdparty/stout/tests/os/filesystem_tests.cpp > e445daf9ed4e4c0d44dbb95e1cbebd0342c1acbc > 3rdparty/stout/tests/os/rmdir_tests.cpp > ed43b44663cbf04d7ddb449fd9f42b8de210bc6e > 3rdparty/stout/tests/os_tests.cpp 8b9531443f625ae0e1f00d29e9e45299f181880e > > > Diff: https://reviews.apache.org/r/57824/diff/1/ > > > Testing > ------- > > > Thanks, > > John Kordich > >
