----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/#review171512 -----------------------------------------------------------
Fix it, then Ship it! I can fix the below issues for you, before committing. I'd recommend taking a glance at the commit after I've pushed it, so that you can cross reference the comments with the actual change I made. 3rdparty/stout/include/stout/tests/environment.hpp Lines 38-59 (patched) <https://reviews.apache.org/r/57824/#comment244456> I know this was copy-pasted from the source in the Mesos tests, but most of these headers are un-used. You can whittle these headers down to: ``` #include <stout/error.hpp> #include <stout/fs.hpp> #include <stout/option.hpp> #include <stout/os.hpp> #include <stout/path.hpp> #include <stout/strings.hpp> #include <stout/try.hpp> #include <stout/os/getcwd.hpp> ``` 3rdparty/stout/tests/main.cpp Lines 23 (patched) <https://reviews.apache.org/r/57824/#comment244558> Note: For the autotools builds, you'll need to add the new header to `3rdparty/stout/include/Makefile.am`. 3rdparty/stout/tests/main.cpp Lines 27 (patched) <https://reviews.apache.org/r/57824/#comment244563> The only reason why the `Environment*` pointer is kept in global scope in `src/tests/environment` is for the `environment->mkdtemp` function. Since we don't have such a function for stout tests, we can just keep the pointer inside the main function. - Joseph Wu On April 10, 2017, 2:41 p.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57824/ > ----------------------------------------------------------- > > (Updated April 10, 2017, 2:41 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Bugs: MESOS-6731 > https://issues.apache.org/jira/browse/MESOS-6731 > > > Repository: mesos > > > Description > ------- > > Filtered stout tests with symlinks when unable to create symlinks. > > > Diffs > ----- > > 3rdparty/stout/include/stout/tests/environment.hpp PRE-CREATION > 3rdparty/stout/tests/main.cpp f41b29c087402d5dbed1144504980746e0e9b6da > 3rdparty/stout/tests/os/filesystem_tests.cpp > e445daf9ed4e4c0d44dbb95e1cbebd0342c1acbc > 3rdparty/stout/tests/os/rmdir_tests.cpp > ed43b44663cbf04d7ddb449fd9f42b8de210bc6e > 3rdparty/stout/tests/os_tests.cpp 8b9531443f625ae0e1f00d29e9e45299f181880e > > > Diff: https://reviews.apache.org/r/57824/diff/4/ > > > Testing > ------- > > Ran make check on Linux and the tests on Windows. > > > Thanks, > > John Kordich > >
