----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/#review172188 -----------------------------------------------------------
Because I need to implement similar filters for tests in `libprocess`, wouldn't it have been better to create a `Filter` abstraction in stout and using that here as well as in Mesos instead of copy-pasting the implementation of Mesos? Also the copied Mesos code seems to not quite fit the stout code-style, e.g. it uses camel case instead of snake case. - Jan Schlicht On April 10, 2017, 11:41 p.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57824/ > ----------------------------------------------------------- > > (Updated April 10, 2017, 11:41 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Bugs: MESOS-6731 > https://issues.apache.org/jira/browse/MESOS-6731 > > > Repository: mesos > > > Description > ------- > > Filtered stout tests with symlinks when unable to create symlinks. > > > Diffs > ----- > > 3rdparty/stout/include/stout/tests/environment.hpp PRE-CREATION > 3rdparty/stout/tests/main.cpp f41b29c087402d5dbed1144504980746e0e9b6da > 3rdparty/stout/tests/os/filesystem_tests.cpp > e445daf9ed4e4c0d44dbb95e1cbebd0342c1acbc > 3rdparty/stout/tests/os/rmdir_tests.cpp > ed43b44663cbf04d7ddb449fd9f42b8de210bc6e > 3rdparty/stout/tests/os_tests.cpp 8b9531443f625ae0e1f00d29e9e45299f181880e > > > Diff: https://reviews.apache.org/r/57824/diff/4/ > > > Testing > ------- > > Ran make check on Linux and the tests on Windows. > > > Thanks, > > John Kordich > >
