----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57854/#review169944 -----------------------------------------------------------
src/checks/checker.cpp Line 626 (original), 627 (patched) <https://reviews.apache.org/r/57854/#comment242663> This leads to the test failure: [ FAILED ] CheckTest.CheckInfoValidation Please adjust the test. src/checks/checker.cpp Line 699 (original), 700 (patched) <https://reviews.apache.org/r/57854/#comment242664> This leads to the test failure: [ FAILED ] CheckTest.CheckStatusInfoValidation Please adjust the test. - Alexander Rukletsov On March 23, 2017, 8:19 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57854/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 8:19 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > ------- > > - Made log/failure messages consistent across both libraries. > - Task and container IDs are user generated and can contain spaces, so > we have to wrap them in single quotes. > - Removed the redundant task IDs from 'Failure' messages. > > > Diffs > ----- > > src/checks/checker.cpp 314354cc374b453ec12e25e3d4730a92697468cf > src/checks/health_checker.cpp a26e9b570ea3a0ee775d220a3b523ae7052dad23 > > > Diff: https://reviews.apache.org/r/57854/diff/5/ > > > Testing > ------- > > Did some manual testing and looked at the new log messages, they're so much > nicer now <3. > > > Thanks, > > Gastón Kleiman > >
