----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57854/#review170009 -----------------------------------------------------------
Patch looks great! Reviews applied: [57644, 57648, 56288, 55901, 57645, 57646, 57647, 57854] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 24, 2017, 7:49 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57854/ > ----------------------------------------------------------- > > (Updated March 24, 2017, 7:49 a.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > - Made log/failure messages consistent across both libraries. > - Task and container IDs are user generated and can contain spaces, so > we have to wrap them in single quotes. > - Removed the redundant task IDs from 'Failure' messages. > > > Diffs > ----- > > src/checks/checker.cpp 314354cc374b453ec12e25e3d4730a92697468cf > src/checks/health_checker.cpp 2211228f7aa0228af64d8fce6c5f2dd1847328f9 > src/tests/check_tests.cpp 16f1c07e109e24d475ad593ef1992dfb9f482ba6 > > > Diff: https://reviews.apache.org/r/57854/diff/7/ > > > Testing > ------- > > Did some manual testing and looked at the new log messages, they're so much > nicer now <3. > > > Thanks, > > Gastón Kleiman > >
