----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57854/#review169993 -----------------------------------------------------------
Bad patch! Reviews applied: [57854, 57647, 57646, 57645, 55901, 56288, 57648, 57644] Failed command: python support/apply-reviews.py -n -r 57854 Error: 2017-03-24 09:10:48 URL:https://reviews.apache.org/r/57854/diff/raw/ [24738/24738] -> "57854.patch" [1] error: patch failed: src/checks/health_checker.cpp:532 error: src/checks/health_checker.cpp: patch does not apply Full log: https://builds.apache.org/job/Mesos-Reviewbot/17546/console - Mesos Reviewbot On March 24, 2017, 4:42 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57854/ > ----------------------------------------------------------- > > (Updated March 24, 2017, 4:42 a.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > - Made log/failure messages consistent across both libraries. > - Task and container IDs are user generated and can contain spaces, so > we have to wrap them in single quotes. > - Removed the redundant task IDs from 'Failure' messages. > > > Diffs > ----- > > src/checks/checker.cpp 314354cc374b453ec12e25e3d4730a92697468cf > src/checks/health_checker.cpp a26e9b570ea3a0ee775d220a3b523ae7052dad23 > src/tests/check_tests.cpp f035c16920deaf559420ae0d7d881330ff65ae44 > > > Diff: https://reviews.apache.org/r/57854/diff/6/ > > > Testing > ------- > > Did some manual testing and looked at the new log messages, they're so much > nicer now <3. > > > Thanks, > > Gastón Kleiman > >
