----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/#review170997 -----------------------------------------------------------
Fix it, then Ship it! src/master/allocator/mesos/hierarchical.hpp Line 304 (original), 305 (patched) <https://reviews.apache.org/r/57817/#comment243827> Undo this change? src/master/allocator/mesos/hierarchical.cpp Line 271 (original), 272 (patched) <https://reviews.apache.org/r/57817/#comment243828> Remove double space after `framework`. - James Peach On April 3, 2017, 10:35 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57817/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 10:35 p.m.) > > > Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-7015 > https://issues.apache.org/jira/browse/MESOS-7015 > > > Repository: mesos > > > Description > ------- > > If requested in SUBSCRIBE api call, offers are suppressed on > framework registration. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > 6eda1b8619269c1501a935045b18b1deaf845b33 > src/master/allocator/mesos/allocator.hpp > 57b54b86c43c7731e64d422d285c4b8ca7e27a60 > src/master/allocator/mesos/hierarchical.hpp > f84b0574ce9a392c9528c87b04b01dbb2053cff7 > src/master/allocator/mesos/hierarchical.cpp > ff9e2340e88f50f02aa8ebfd6b6ce039f347bb5d > src/master/master.hpp 1b077424373d6e195e4ab29e150dedbc3f3f95ab > src/master/master.cpp 6a6a570e52d21bfb2443f981e3d7faf8c36f74bc > src/tests/allocator.hpp 6b71c574e0e4facd1795ef50ee0869c03b87833d > src/tests/hierarchical_allocator_tests.cpp > e343dc37bd7136f0f6dd5dbc22a25cabe715038d > src/tests/master_allocator_tests.cpp > 9f3750215f2b72f6148d0c47cdde6a3f7dfb1b50 > src/tests/persistent_volume_endpoints_tests.cpp > d5fcdbf7575acf99d5dec5315aee127f14e54e6d > src/tests/reservation_tests.cpp 4504831d77c1bfcf5f2ddf6d28cd45dea2c421ad > src/tests/resource_offers_tests.cpp > f0bca1d9e03013ce35215b0ffa6b50b38972dc0c > src/tests/slave_recovery_tests.cpp 53f33a2b0411c8158326074ce043c7b1dbeef5b4 > > > Diff: https://reviews.apache.org/r/57817/diff/2/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
