----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/#review170782 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp Line 238 (original), 240 (patched) <https://reviews.apache.org/r/57817/#comment243662> Why do you need to set the `suppressed` flag here, when you call `suppressOffers` below? src/master/allocator/mesos/hierarchical.cpp Line 271 (original), 273 (patched) <https://reviews.apache.org/r/57817/#comment243661> Consider updating this log to specify whether the framwork was initially suppressed. src/master/allocator/mesos/hierarchical.cpp Lines 275 (patched) <https://reviews.apache.org/r/57817/#comment243660> Consider: ``` if (offersSuppressed) { ... } else if (active) { ... } else { ... } ``` - James Peach On March 31, 2017, 8:20 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57817/ > ----------------------------------------------------------- > > (Updated March 31, 2017, 8:20 p.m.) > > > Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-7015 > https://issues.apache.org/jira/browse/MESOS-7015 > > > Repository: mesos > > > Description > ------- > > If requested in SUBSCRIBE api call, offers are suppressed on > framework registration. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > 6eda1b8619269c1501a935045b18b1deaf845b33 > src/master/allocator/mesos/allocator.hpp > 57b54b86c43c7731e64d422d285c4b8ca7e27a60 > src/master/allocator/mesos/hierarchical.hpp > f84b0574ce9a392c9528c87b04b01dbb2053cff7 > src/master/allocator/mesos/hierarchical.cpp > 8d54a8cca1bb478f4437f68c5e14f66a9f9bb9e9 > src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 > src/master/master.cpp 43e9d26167c1f405329ea05224c22e7b8c65315f > src/tests/allocator.hpp 6b71c574e0e4facd1795ef50ee0869c03b87833d > src/tests/hierarchical_allocator_tests.cpp > e343dc37bd7136f0f6dd5dbc22a25cabe715038d > src/tests/master_allocator_tests.cpp > 9f3750215f2b72f6148d0c47cdde6a3f7dfb1b50 > src/tests/persistent_volume_endpoints_tests.cpp > d5fcdbf7575acf99d5dec5315aee127f14e54e6d > src/tests/reservation_tests.cpp 4504831d77c1bfcf5f2ddf6d28cd45dea2c421ad > src/tests/resource_offers_tests.cpp > f0bca1d9e03013ce35215b0ffa6b50b38972dc0c > src/tests/slave_recovery_tests.cpp 09bfa75dd03fa19fba2c9dee15d29d703ca02f29 > > > Diff: https://reviews.apache.org/r/57817/diff/1/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
