> On April 27, 2017, 11:05 p.m., Alexander Rojas wrote: > > src/tests/master_authorization_tests.cpp > > Line 2063 (original), 2062 (patched) > > <https://reviews.apache.org/r/58097/diff/4/?file=1694001#file1694001line2063> > > > > Not yours, but no test verifies that the serialzation of quotas/weights > > is done correctly. Since you are changing how it is performed, coul you > > test that too?
I feel `RoleTest` is sufficient, no? - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58097/#review173207 ----------------------------------------------------------- On May 8, 2017, 3:56 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58097/ > ----------------------------------------------------------- > > (Updated May 8, 2017, 3:56 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler. > > > Bugs: MESOS-7260 > https://issues.apache.org/jira/browse/MESOS-7260 > > > Repository: mesos > > > Description > ------- > > Added a test to check framework filtering in /roles endpoint. > > > Diffs > ----- > > src/tests/master_authorization_tests.cpp > e4233c19b1d9e3e2734259503d0daec4ce243667 > > > Diff: https://reviews.apache.org/r/58097/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Jay Guo > >
