----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/#review177675 -----------------------------------------------------------
Fix it, then Ship it! Looks great - just one lil ancient include omission we might want to fix before committing. Also I was wondering if we should adapt the header comment test-descriptions with our authorization additions - e.g. I'll leave that up to you to decide if or how. As an example: ``` // In this test case, we start maintenance on a machine and stop maintenance, // and then verify that the associated maintenance window disappears. TEST_P(MasterAPITest, StartAndStopMaintenance) ``` This one by now actually also tests if ACLs preventing from engaging maintenance works as expected - seems an interesting detail, no? src/master/master.hpp Line 30 (original), 30 (patched) <https://reviews.apache.org/r/59147/#comment251365> Aren't we missing ``` #include <mesos/authorizer/authorizer.hpp> ``` src/tests/api_tests.cpp Lines 1436-1441 (original), 1456-1458 (patched) <https://reviews.apache.org/r/59147/#comment251364> Thanks for these - much appreciated. - Till Toenshoff On June 12, 2017, 5:30 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59147/ > ----------------------------------------------------------- > > (Updated June 12, 2017, 5:30 p.m.) > > > Review request for mesos, Adam B, Greg Mann, and Till Toenshoff. > > > Bugs: MESOS-7415 > https://issues.apache.org/jira/browse/MESOS-7415 > > > Repository: mesos > > > Description > ------- > > Enables the use of authorization for the 'START_MAINTENANCE' and > 'STOP_MAINTENANCE' v1 API calls, using the ACLs 'StartMaintenance' and > 'StopMaintenance' respectively as well the actions of the same name as > the API calls. > > It also updates the ApiTests to take into account the authorization > case. > > > Diffs > ----- > > src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 > src/master/master.hpp e8ddddf273256b14cde1cac390163f948241757f > src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 > src/tests/master_maintenance_tests.cpp > 9edd74a876cd2933d5a5be590a7dd3d10bc54253 > > > Diff: https://reviews.apache.org/r/59147/diff/7/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
