> On June 12, 2017, 9:57 p.m., Till Toenshoff wrote: > > src/master/master.hpp > > Line 30 (original), 30 (patched) > > <https://reviews.apache.org/r/59147/diff/7/?file=1748822#file1748822line30> > > > > Aren't we missing > > ``` > > #include <mesos/authorizer/authorizer.hpp> > > ``` > > Alexander Rojas wrote: > Nope, the authorizer is forward delcared > [here](https://github.com/apache/mesos/blob/03342092988bf62a90d429309ab95f0c36a3c851/src/master/master.hpp#L94) > and the included in > [cpp](https://github.com/apache/mesos/blob/03342092988bf62a90d429309ab95f0c36a3c851/src/master/master.cpp#L33)
That may be true but the `ObjectApprover` is not forward declared or included. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/#review177675 ----------------------------------------------------------- On June 12, 2017, 5:30 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59147/ > ----------------------------------------------------------- > > (Updated June 12, 2017, 5:30 p.m.) > > > Review request for mesos, Adam B, Greg Mann, and Till Toenshoff. > > > Bugs: MESOS-7415 > https://issues.apache.org/jira/browse/MESOS-7415 > > > Repository: mesos > > > Description > ------- > > Enables the use of authorization for the 'START_MAINTENANCE' and > 'STOP_MAINTENANCE' v1 API calls, using the ACLs 'StartMaintenance' and > 'StopMaintenance' respectively as well the actions of the same name as > the API calls. > > It also updates the ApiTests to take into account the authorization > case. > > > Diffs > ----- > > src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 > src/master/master.hpp e8ddddf273256b14cde1cac390163f948241757f > src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 > src/tests/master_maintenance_tests.cpp > 9edd74a876cd2933d5a5be590a7dd3d10bc54253 > > > Diff: https://reviews.apache.org/r/59147/diff/7/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
