----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60369/#review178867 -----------------------------------------------------------
src/slave/http.cpp Lines 1317-1318 (patched) <https://reviews.apache.org/r/60369/#comment253163> Do we need this comment? Seems clear from the code src/slave/http.cpp Lines 1322 (patched) <https://reviews.apache.org/r/60369/#comment253164> I'm not sure that it makes sense to be filtering in this manner here, since the user is not viewing the framework or executor, but rather the resources allocated to roles. It seems like this should be doing role-based authorization instead, as is done in the master side role endpoint: https://github.com/apache/mesos/blob/6b0ce8ff80e315fdfb22f0d7a2ed6d0947be7f11/src/master/http.cpp#L3363-L3420 src/tests/reservation_endpoints_tests.cpp Lines 1747 (patched) <https://reviews.apache.org/r/60369/#comment253345> This flag is deprecated now that we can persist role configuration within the registry, did you need to set this for the test to pass? - Benjamin Mahler On June 22, 2017, 3:26 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60369/ > ----------------------------------------------------------- > > (Updated June 22, 2017, 3:26 p.m.) > > > Review request for mesos, Benjamin Mahler and haosdent huang. > > > Bugs: MESOS-6441 > https://issues.apache.org/jira/browse/MESOS-6441 > > > Repository: mesos > > > Description > ------- > > The JSON key for this information is "reserved_resources_allocated" > and "unreserved_resources_allocated". > > > Diffs > ----- > > src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c > src/tests/reservation_endpoints_tests.cpp > f710a188a7875c1cb847e39276b4b65332703ca5 > > > Diff: https://reviews.apache.org/r/60369/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Andrei Budnik > >
