> On June 27, 2017, 10:39 a.m., Benjamin Mahler wrote: > > src/slave/http.cpp > > Lines 1317-1318 (patched) > > <https://reviews.apache.org/r/60369/diff/1/?file=1758431#file1758431line1317> > > > > Do we need this comment? Seems clear from the code
Fixed. > On June 27, 2017, 10:39 a.m., Benjamin Mahler wrote: > > src/slave/http.cpp > > Lines 1322 (patched) > > <https://reviews.apache.org/r/60369/diff/1/?file=1758431#file1758431line1322> > > > > I'm not sure that it makes sense to be filtering in this manner here, > > since the user is not viewing the framework or executor, but rather the > > resources allocated to roles. It seems like this should be doing role-based > > authorization instead, as is done in the master side role endpoint: > > > > > > https://github.com/apache/mesos/blob/6b0ce8ff80e315fdfb22f0d7a2ed6d0947be7f11/src/master/http.cpp#L3363-L3420 Fixed. > On June 27, 2017, 10:39 a.m., Benjamin Mahler wrote: > > src/tests/reservation_endpoints_tests.cpp > > Lines 1747 (patched) > > <https://reviews.apache.org/r/60369/diff/1/?file=1758432#file1758432line1747> > > > > This flag is deprecated now that we can persist role configuration > > within the registry, did you need to set this for the test to pass? I'm getting following error without this flag: `Function call: error(0x7fff595959d8, @0x7facca60abd0 "Roles { role1 } are not present in the master's --roles")` - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60369/#review178867 ----------------------------------------------------------- On June 27, 2017, 5:10 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60369/ > ----------------------------------------------------------- > > (Updated June 27, 2017, 5:10 p.m.) > > > Review request for mesos, Benjamin Mahler and haosdent huang. > > > Bugs: MESOS-6441 > https://issues.apache.org/jira/browse/MESOS-6441 > > > Repository: mesos > > > Description > ------- > > The JSON key for this information is "reserved_resources_allocated" > and "unreserved_resources_allocated". > > > Diffs > ----- > > src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c > src/tests/reservation_endpoints_tests.cpp > f710a188a7875c1cb847e39276b4b65332703ca5 > > > Diff: https://reviews.apache.org/r/60369/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Andrei Budnik > >
