-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60508/#review179181
-----------------------------------------------------------
Bad patch!
Reviews applied: [60508]
Failed command: python support/apply-reviews.py -n -r 60508
Error:
Traceback (most recent call last):
File "support/apply-reviews.py", line 417, in <module>
main()
File "support/apply-reviews.py", line 412, in main
reviewboard(options)
File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
File "support/apply-reviews.py", line 158, in apply_review
fetch_patch(options)
File "support/apply-reviews.py", line 194, in fetch_patch
patch.write(patch.read())
IOError: File not open for reading
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/124/console
- Mesos Reviewbot Windows
On June 28, 2017, 5:36 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60508/
> -----------------------------------------------------------
>
> (Updated June 28, 2017, 5:36 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1216
> https://issues.apache.org/jira/browse/MESOS-1216
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently we don't enforce attribute name uniqueness. But the comparison
> operator for `Attributes` expects that attribute name and type are
> unique. This causes causes agent recovery failure.
>
> This fixes the issue by allowing multiple attributes of same name and
> type.
>
>
> Diffs
> -----
>
> include/mesos/attributes.hpp 641febbd3bc3700b2c088f4388d8e6f18e6b078a
> include/mesos/v1/attributes.hpp 022bfde430c618708843a4d790f3f8a118ae082b
> src/common/attributes.cpp ac683c7fe5b67fb8a73599230a3eb47911293a7e
> src/tests/attributes_tests.cpp cb71be5ecead322d90943146f54f8a0c915eba1c
> src/v1/attributes.cpp 409d66453c492a329adc4e16312924e21a6d4709
>
>
> Diff: https://reviews.apache.org/r/60508/diff/1/
>
>
> Testing
> -------
>
> Added a test to `AttributesTest.Equality`. Ran `make check`. Verified
> manually by failing over the agent with multiple attributes with the same
> name.
>
>
> Thanks,
>
> Ilya Pronin
>
>
