-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60508/
-----------------------------------------------------------
(Updated Aug. 3, 2017, 1:11 p.m.)
Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
Changes
-------
Addressed comments.
Bugs: MESOS-1216
https://issues.apache.org/jira/browse/MESOS-1216
Repository: mesos
Description
-------
Currently we don't enforce attribute name uniqueness. But the comparison
operator for `Attributes` expects that attribute name and type are
unique. This causes causes agent recovery failure.
This fixes the issue by allowing multiple attributes of same name and
type.
Diffs (updated)
-----
include/mesos/attributes.hpp 641febbd3bc3700b2c088f4388d8e6f18e6b078a
include/mesos/v1/attributes.hpp 022bfde430c618708843a4d790f3f8a118ae082b
src/common/attributes.cpp ac683c7fe5b67fb8a73599230a3eb47911293a7e
src/tests/attributes_tests.cpp cb71be5ecead322d90943146f54f8a0c915eba1c
src/v1/attributes.cpp 409d66453c492a329adc4e16312924e21a6d4709
Diff: https://reviews.apache.org/r/60508/diff/2/
Changes: https://reviews.apache.org/r/60508/diff/1-2/
Testing
-------
Added a test to `AttributesTest.Equality`. Ran `make check`. Verified manually
by failing over the agent with multiple attributes with the same name.
Thanks,
Ilya Pronin
