-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60581/
-----------------------------------------------------------
(Updated June 30, 2017, 10:44 p.m.)
Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod
Kone.
Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630
Repository: mesos
Description (updated)
-------
Added filtering to the '/slaves' endpoint.
Added query parameter support for 'slaves'
endpoint. We can use 'slave_id' to specify
which slave information to query. Thus it
looks like '/slaves?slave_id=[slave id]'
If not slave id is specified, it will return
information of all slaves, just like before
The structure for response is the same for both
specifying or not specifying slave id. Thus even
for request with slave id specified, the response
will still contain both fields 'slaves',
'recovered_slaves' etc..
Diffs (updated)
-----
src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e
src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6
src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67
src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea
Diff: https://reviews.apache.org/r/60581/diff/2/
Changes: https://reviews.apache.org/r/60581/diff/1-2/
Testing
-------
Passed 'make check -j48'
Passed 'GTEST_FILTER="MasterTest.SlavesEndpointQuerySlave" make check -j48'
Passed 'GLOG_v=1 ./bin/mesos-tests.sh
--gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000
--gtest_break_on_failure'
Thanks,
Quinn Leng
