-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60581/
-----------------------------------------------------------
(Updated July 5, 2017, 4:28 p.m.)
Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod
Kone.
Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630
Repository: mesos
Description (updated)
-------
Added filtering to the '/slaves' endpoint.
Added query parameter support for 'slaves'
endpoint. We can use 'slave_id' to specify
which slave information to query. Thus it
looks like '/slaves?slave_id=[slave id]'
If not slave id is specified, it will return
information of all slaves, just like before
The structure for response is the same for both
specifying or not specifying slave id. Thus even
for request with slave id specified, the response
will still contain both fields 'slaves',
'recovered_slaves' etc..
Diffs
-----
src/common/http.hpp b7e4a8adcbcaa3a962af795c67694a35161b6c1a
src/common/http.cpp fdb591eccf273260902f3f695cf431f72ee3d817
src/master/http.cpp 64b7cdd1c42a067bf24e302b9496bb75cb916590
src/tests/master_tests.cpp d21194fb19781a24223d6b0d8f99987f4edb5a9a
Diff: https://reviews.apache.org/r/60581/diff/3/
Testing
-------
Passed 'make check -j48'
Passed 'GTEST_FILTER="MasterTest.SlavesEndpointQuerySlave" make check -j48'
Passed 'GLOG_v=1 ./bin/mesos-tests.sh
--gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000
--gtest_break_on_failure'
Thanks,
Quinn Leng
