> On July 4, 2017, 12:10 p.m., Benjamin Bannier wrote: > > I am confused why we need this at all at this point. With > > https://reviews.apache.org/r/60439/ we should be able to generate the site > > locally and look at its output. Executing the rake rules is already now > > pretty much possible (on macOS `rake` needs to be added to the `Gemfile`) > > if the needed tools are locally available, if not, we provide the > > container. We seem to add a lot of elaborate tooling to isolate us from > > something which is already an abstraction (i.e., docker around rake). > > > > Can we get rid of this container completely and instead streamline the > > existing `support/website` and `site/Rakefile` toolings instead of adding > > another one?
See comment above. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60440/#review179567 ----------------------------------------------------------- On June 29, 2017, 9:59 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60440/ > ----------------------------------------------------------- > > (Updated June 29, 2017, 9:59 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and haosdent > huang. > > > Bugs: MESOS-7625 > https://issues.apache.org/jira/browse/MESOS-7625 > > > Repository: mesos > > > Description > ------- > > Made the layout and scripts consistent with CI based automatic > publishing of the website. > > > Diffs > ----- > > site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 > site/README.md ebd3e6a0fea7ae0fe3b28719bcab28ee8f7c356c > site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 > site/entrypoint.sh PRE-CREATION > site/mesos-website-dev.sh PRE-CREATION > > > Diff: https://reviews.apache.org/r/60440/diff/1/ > > > Testing > ------- > > Tested by running the script locally. > > > Thanks, > > Vinod Kone > >
