----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59127/#review179692 -----------------------------------------------------------
src/slave/flags.hpp Line 173 (original), 173 (patched) <https://reviews.apache.org/r/59127/#comment254509> Let's keep this generic to IP not IPv4 and add validation like you did in libprocess that we currently only support IPv4. src/slave/flags.hpp Lines 181-182 (original), 181-182 (patched) <https://reviews.apache.org/r/59127/#comment254510> s/IPv4/IP/g src/slave/flags.hpp Lines 187-190 (patched) <https://reviews.apache.org/r/59127/#comment254511> How about printing this out as a warning as part of some validation logic so that users that set this understand that they're not getting what they might think they're getting? src/slave/flags.cpp Lines 1101-1104 (patched) <https://reviews.apache.org/r/59127/#comment254512> I'd like to make the comments be the same as for the `--ip` set of flags with an extra comment that currently the flag is ONLY being used to "advertise containers running on the IPv6 network ..." etc. Because the long term intention is that this will also be used for specifying a flag that we'll bind to? - Benjamin Hindman On June 29, 2017, 11:25 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59127/ > ----------------------------------------------------------- > > (Updated June 29, 2017, 11:25 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-7488 > https://issues.apache.org/jira/browse/MESOS-7488 > > > Repository: mesos > > > Description > ------- > > Added IPv6 flags for Mesos agent. > > > Diffs > ----- > > src/slave/flags.hpp e75c1b4227b443aedf445921b3f2108d930c112c > src/slave/flags.cpp c84aa6724170bba46b4444be8410b71d42a1626e > > > Diff: https://reviews.apache.org/r/59127/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Avinash sridharan > >
