> On July 5, 2017, 7:57 p.m., Benjamin Hindman wrote: > > src/slave/flags.hpp > > Line 173 (original), 173 (patched) > > <https://reviews.apache.org/r/59127/diff/4/?file=1767256#file1767256line173> > > > > Let's keep this generic to IP not IPv4 and add validation like you did > > in libprocess that we currently only support IPv4.
I haven't added a validation check here since the `ip` here is just a string. This is anyway passed onto `libprocess` where its converted to `net::IP` and the validation kicks in. > On July 5, 2017, 7:57 p.m., Benjamin Hindman wrote: > > src/slave/flags.hpp > > Lines 187-190 (patched) > > <https://reviews.apache.org/r/59127/diff/4/?file=1767256#file1767256line187> > > > > How about printing this out as a warning as part of some validation > > logic so that users that set this understand that they're not getting what > > they might think they're getting? Added a `LOG(WARNING) in the flag validation. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59127/#review179692 ----------------------------------------------------------- On July 7, 2017, 1:02 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59127/ > ----------------------------------------------------------- > > (Updated July 7, 2017, 1:02 a.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-7488 > https://issues.apache.org/jira/browse/MESOS-7488 > > > Repository: mesos > > > Description > ------- > > Added IPv6 flags for Mesos agent. > > > Diffs > ----- > > src/slave/flags.hpp c6803eb54e09a5497755e1e5fef2872193eacba6 > src/slave/flags.cpp 398768656b5fa3b7c85474de2b4b008bf7b85cb3 > > > Diff: https://reviews.apache.org/r/59127/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Avinash sridharan > >
