-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60525/#review180358
-----------------------------------------------------------
Bad patch!
Reviews applied: [60525, 60721, 60524]
Failed command: python support/apply-reviews.py -n -r 60524
Error:
Traceback (most recent call last):
File "support/apply-reviews.py", line 417, in <module>
main()
File "support/apply-reviews.py", line 412, in main
reviewboard(options)
File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
File "support/apply-reviews.py", line 160, in apply_review
commit_patch(options)
File "support/apply-reviews.py", line 268, in commit_patch
shell(cmd, options['dry_run'])
File "support/apply-reviews.py", line 144, in shell
error_code = subprocess.call(command, stderr=subprocess.STDOUT, shell=True)
File "C:\Python27\lib\subprocess.py", line 168, in call
return Popen(*popenargs, **kwargs).wait()
File "C:\Python27\lib\subprocess.py", line 390, in __init__
errread, errwrite)
File "C:\Python27\lib\subprocess.py", line 610, in _execute_child
args = '{} /c "{}"'.format (comspec, args)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position
25: ordinal not in range(128)
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/141/console
- Mesos Reviewbot Windows
On July 12, 2017, 9:41 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60525/
> -----------------------------------------------------------
>
> (Updated July 12, 2017, 9:41 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann,
> and Vinod Kone.
>
>
> Bugs: MESOS-7660
> https://issues.apache.org/jira/browse/MESOS-7660
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If a framework accepts/refuses an offer using a very long filter, the
> `HierarchicalAllocator` will use the default filter instead. Meaning
> that it will filter the resources for only 5 seconds. This can happen
> when a framework sets `Filter::refuse_seconds` to a number of seconds
> larger than what fits in `Duration`.
>
> This patch makes the allocator use the largest possible filter duration
> in this case.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp
> f021c34ef11aac42026ba39c5a1b775794982035
>
>
> Diff: https://reviews.apache.org/r/60525/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Gastón Kleiman
>
>
