> On July 10, 2017, 7:52 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1048-1049 (original), 1048-1050 (patched) > > <https://reviews.apache.org/r/60525/diff/3/?file=1771867#file1771867line1048> > > > > We usually use leading spaces instead of trailing spaces, but I see > > that you follow the pattern here. Maybe clean the whole file in a separate > > patch?
https://reviews.apache.org/r/60815/ - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60525/#review180013 ----------------------------------------------------------- On July 12, 2017, 9:41 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60525/ > ----------------------------------------------------------- > > (Updated July 12, 2017, 9:41 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, > and Vinod Kone. > > > Bugs: MESOS-7660 > https://issues.apache.org/jira/browse/MESOS-7660 > > > Repository: mesos > > > Description > ------- > > If a framework accepts/refuses an offer using a very long filter, the > `HierarchicalAllocator` will use the default filter instead. Meaning > that it will filter the resources for only 5 seconds. This can happen > when a framework sets `Filter::refuse_seconds` to a number of seconds > larger than what fits in `Duration`. > > This patch makes the allocator use the largest possible filter duration > in this case. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > f021c34ef11aac42026ba39c5a1b775794982035 > > > Diff: https://reviews.apache.org/r/60525/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Gastón Kleiman > >
