> On Aug. 11, 2017, 7:47 p.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Line 2257 (original), 2258-2262 (patched)
> > <https://reviews.apache.org/r/60525/diff/6/?file=1787910#file1787910line2258>
> >
> >     Is there a suitable place in the documentation for us to mention this?
> >     
> >     Also, could you add an update for the changelog which calls out this 
> > change?

I added something to `docs/scheduler-http-api.md`, most other places that 
mention Filters tell users to look at the protos.


> On Aug. 11, 2017, 7:47 p.m., Greg Mann wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Line 1019 (original), 1019 (patched)
> > <https://reviews.apache.org/r/60525/diff/6/?file=1787912#file1787912line1019>
> >
> >     s/timeout = timeout =/timeout =/

:scream: ;-)


> On Aug. 11, 2017, 7:47 p.m., Greg Mann wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Line 1170 (original), 1180 (patched)
> > <https://reviews.apache.org/r/60525/diff/6/?file=1787912#file1787912line1180>
> >
> >     Ditto

Ohhh no, not again!


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60525/#review182730
-----------------------------------------------------------


On Aug. 12, 2017, 1:07 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60525/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2017, 1:07 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-7660
>     https://issues.apache.org/jira/browse/MESOS-7660
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a framework accepts/refuses an offer using a very long filter, the
> `HierarchicalAllocator` will use the default filter instead. Meaning
> that it will filter the resources for only 5 seconds. This can happen
> when a framework sets `Filter::refuse_seconds` to a number of seconds
> larger than what fits in `Duration`.
> 
> This patch makes the hierarchical allocator cap the filter duration to
> at most 365 days.
> 
> 
> Diffs
> -----
> 
>   docs/scheduler-http-api.md 4a5d77b88ae7cf0a0d8d39fe2579eb68bf33059a 
>   include/mesos/mesos.proto 50a5caf2623fff7d371753cbc6e842779fbf9769 
>   include/mesos/v1/mesos.proto 9d47a8a3a2f10fa493b4db35a73f33e6ee1ac727 
>   src/master/allocator/mesos/hierarchical.cpp 
> f021c34ef11aac42026ba39c5a1b775794982035 
> 
> 
> Diff: https://reviews.apache.org/r/60525/diff/7/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Reply via email to