----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60892/#review180621 -----------------------------------------------------------
Fix it, then Ship it! Other than style, this patch looks good. src/slave/paths.cpp Line 91 (original), 91 (patched) <https://reviews.apache.org/r/60892/#comment255820> This line should be broken at 80 characters per the style guide. But otherwise looks good. - Andrew Schwartzmeyer On July 15, 2017, 1:13 a.m., Li Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60892/ > ----------------------------------------------------------- > > (Updated July 15, 2017, 1:13 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Bugs: MESOS-7797 > https://issues.apache.org/jira/browse/MESOS-7797 > > > Repository: mesos > > > Description > ------- > > Fixed the hard-coded forward slash which breaks windows docker container task > launching in DC/OS path > > > Diffs > ----- > > src/slave/paths.cpp c08e83c14be30c9ef376326d23a8ec6b6b9ff246 > > > Diff: https://reviews.apache.org/r/60892/diff/1/ > > > Testing > ------- > > Testing Done on Windows system, including all unit test. Also verify that > with the fix the Windows docker container could be launched properly in DC/OS. > > > Thanks, > > Li Li > >
