----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60892/#review180624 -----------------------------------------------------------
Ship it! This is a small fix, so I'm going to point out the things I modified and just make them before committing: * The commit message is limited to 72 characters, so I'll rephrase it. * There is a test `PathsTest.ParseExecutorRunPath` in src/tests/paths_tests.cpp which exercises this function. I will un-disable it since it will pass now. src/slave/paths.cpp Line 91 (original), 91 (patched) <https://reviews.apache.org/r/60892/#comment255823> This line should be broken into 2 lines, to fit under the 80 character line limit. - Joseph Wu On July 14, 2017, 6:13 p.m., Li Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60892/ > ----------------------------------------------------------- > > (Updated July 14, 2017, 6:13 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Bugs: MESOS-7797 > https://issues.apache.org/jira/browse/MESOS-7797 > > > Repository: mesos > > > Description > ------- > > Fixed the hard-coded forward slash which breaks windows docker container task > launching in DC/OS path > > > Diffs > ----- > > src/slave/paths.cpp c08e83c14be30c9ef376326d23a8ec6b6b9ff246 > > > Diff: https://reviews.apache.org/r/60892/diff/1/ > > > Testing > ------- > > Testing Done on Windows system, including all unit tests. Also verify that > with the fix the Windows docker container could be launched properly in DC/OS. > > > Thanks, > > Li Li > >
