----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60907/#review180777 -----------------------------------------------------------
Ship it! src/slave/slave.cpp Line 4626 (original), 4604 (patched) <https://reviews.apache.org/r/60907/#comment256003> Interesting, this looks like a bug before: `Slave::__run` calls `containerizer->update` including the queued tasks, and immediately afterwards `Slave::_statusUpdate` calls `containerizer->update` without the queued tasks, and the executor becomes sized below what it should be! - Benjamin Mahler On July 17, 2017, 12:09 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60907/ > ----------------------------------------------------------- > > (Updated July 17, 2017, 12:09 p.m.) > > > Review request for mesos, Benjamin Mahler and haosdent huang. > > > Bugs: MESOS-6441 > https://issues.apache.org/jira/browse/MESOS-6441 > > > Repository: mesos > > > Description > ------- > > `allocatedResources()` method is used instead of executor's variable > `resources`, which doesn't include resources of pending tasks. > > > Diffs > ----- > > src/slave/http.cpp 60640e5dbf6c3f8c709351e77ca89f287cf12fc3 > src/slave/slave.hpp 8bb03ecd86bfd87dfd27a800910130aec04e0919 > src/slave/slave.cpp adbe65fbb7c555b098eaae228c7277402452d8a2 > > > Diff: https://reviews.apache.org/r/60907/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Andrei Budnik > >
