----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review181121 -----------------------------------------------------------
src/messages/flags.proto Lines 41 (patched) <https://reviews.apache.org/r/60500/#comment256547> Can we do `MesosDNS`? Following the cadence of `ContainerInfo` and `MesosInfo`, this would be `ContainerDNS` and `MesosDNS`? src/messages/flags.proto Lines 43 (patched) <https://reviews.apache.org/r/60500/#comment256550> s/Not supported yet/Currently not supported. src/messages/flags.proto Lines 44 (patched) <https://reviews.apache.org/r/60500/#comment256548> I know we are using this `USER` mode from the docker terminology, but I would really like to move away from that terminology if possible and be explicit here that this is a CNI network? Instead of calling this mode `USER` can we just call it `CNI? src/messages/flags.proto Lines 49-54 (patched) <https://reviews.apache.org/r/60500/#comment256549> Can we change this to: This field is valid only when the `network_mode` is set to `CNI`. It is invalid when the `network_mode` is `HOST`. When the mode is `CNI` this field informs the `network/cni` isolator about the `CNI` network to which the DNS configuration applies. Also, if the mode is `CNI` and this field is not set it implies wild card semantics for the CNI network name, informing the `network/cni` isolator that the DNS configuration applies to "all" CNI networks. NOTE: If there are multiple `MesosDNS` configuration specified, when applyig a DNS configuration to a CNI network the container will always choose the most specific match based on the CNI network name. src/messages/flags.proto Lines 63 (patched) <https://reviews.apache.org/r/60500/#comment256551> s/Not supported yet/Currently not supported. src/messages/flags.proto Lines 70-75 (patched) <https://reviews.apache.org/r/60500/#comment256554> This field is valid only when the mode is `USER`. For `USER` mode this specified the CNM network to which this DNS configuration applies. Also, if the mode is `USER` and this field is not set it implies wild card semantics for CNM networks, i.e, this DNS configuration applies to all CNM networks. NOTE: In case there are multiple `DockerDNS` specified, when appliying the DNS configuration to a CNM network the containerizer will always choose the most specific match. - Avinash sridharan On July 20, 2017, 12:21 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60500/ > ----------------------------------------------------------- > > (Updated July 20, 2017, 12:21 p.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-7709 > https://issues.apache.org/jira/browse/MESOS-7709 > > > Repository: mesos > > > Description > ------- > > Introduced `--default_container_dns` agent flag. > > > Diffs > ----- > > docs/configuration.md a06ac82e7b908601b9ba97011931276e6292102d > src/messages/flags.hpp 70ad58c33067a0b058deafdcc4ffc5f554b6ca72 > src/messages/flags.proto e87075f19714739b93d9f4aa33ea8686a1bb5613 > src/slave/flags.hpp bf9adf03847a113306c1df2d71e839b90ada7dd3 > src/slave/flags.cpp a4c1a0c62af5506bbeb1d26d2fd9ca0ba11d8ad7 > > > Diff: https://reviews.apache.org/r/60500/diff/3/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
