> On July 25, 2017, 1:46 a.m., Jie Yu wrote: > > src/messages/flags.proto > > Lines 41 (patched) > > <https://reviews.apache.org/r/60500/diff/5/?file=1781150#file1781150line41> > > > > I'd s/MesosDNS/MesosInfo/ here. Same for DockerDNS below. This seems to > > be consistent with what's inside ContainerInfo.
Agree, and I will do s/ContainerDNS/ContainerDNSInfo/ as well. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review181233 ----------------------------------------------------------- On July 24, 2017, 9:39 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60500/ > ----------------------------------------------------------- > > (Updated July 24, 2017, 9:39 a.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-7709 > https://issues.apache.org/jira/browse/MESOS-7709 > > > Repository: mesos > > > Description > ------- > > Introduced `--default_container_dns` agent flag. > > > Diffs > ----- > > docs/configuration.md a06ac82e7b908601b9ba97011931276e6292102d > src/messages/flags.hpp 70ad58c33067a0b058deafdcc4ffc5f554b6ca72 > src/messages/flags.proto e87075f19714739b93d9f4aa33ea8686a1bb5613 > src/slave/flags.hpp bf9adf03847a113306c1df2d71e839b90ada7dd3 > src/slave/flags.cpp a4c1a0c62af5506bbeb1d26d2fd9ca0ba11d8ad7 > src/slave/main.cpp a4a8ced6825ece1b25003824d987ff83fb799ad7 > > > Diff: https://reviews.apache.org/r/60500/diff/5/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
