> On July 25, 2017, 11:33 p.m., Avinash sridharan wrote: > > src/slave/main.cpp > > Lines 411-457 (patched) > > <https://reviews.apache.org/r/60500/diff/6/?file=1781985#file1781985line411> > > > > Shouldn't this be a \lambda? > > > > Similar to how we do error handling for the flags here: > > https://github.com/apache/mesos/blob/master/src/slave/flags.cpp#L329 > > > > Any specific reason we have it part of the code initialization?
My bad, I should have made it a lambda. Thanks Avinash! - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review181349 ----------------------------------------------------------- On July 26, 2017, 10:41 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60500/ > ----------------------------------------------------------- > > (Updated July 26, 2017, 10:41 a.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-7709 > https://issues.apache.org/jira/browse/MESOS-7709 > > > Repository: mesos > > > Description > ------- > > Introduced `--default_container_dns` agent flag. > > > Diffs > ----- > > docs/configuration.md a06ac82e7b908601b9ba97011931276e6292102d > src/messages/flags.hpp 70ad58c33067a0b058deafdcc4ffc5f554b6ca72 > src/messages/flags.proto e87075f19714739b93d9f4aa33ea8686a1bb5613 > src/slave/flags.hpp bf9adf03847a113306c1df2d71e839b90ada7dd3 > src/slave/flags.cpp a4c1a0c62af5506bbeb1d26d2fd9ca0ba11d8ad7 > > > Diff: https://reviews.apache.org/r/60500/diff/7/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
